Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Fix dependencies #217

Merged
merged 9 commits into from
May 6, 2024
Merged

Conversation

xmnlab
Copy link
Member

@xmnlab xmnlab commented Apr 24, 2024

Description

Related Issue

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've used pre-commit hook locally.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.
  • Semantic-release prefix title used (case sensitive):
    • Use the prefix chore(docs): for Examples / docs / tutorials / dependencies update
    • Use the prefix fix: for a bug fix
      (non-breaking change which fixes an issue).
    • Use the prefix chore(improvement): for an improvement
      (non-breaking change which improves an existing feature).
    • Use the prefix feat: for a new feature
      (non-breaking change which adds functionality).
    • Use the prefix BREAKING CHANGE: for a breaking change
      (fix or feature that would cause existing functionality to change).
    • Use the prefix chore(security): for a security fix.

Note: The title prefix can be also expanded with more information
inside the parenthesis. Some examples for a full title (prefix + message):

  • fix(login): Fix the login page.
  • feat(forecast): Add a weather forecast page.
  • chore(security-login): Add a weather forecast page.

@xmnlab xmnlab marked this pull request as ready for review April 24, 2024 17:40
@xmnlab xmnlab requested a review from fccoelho April 24, 2024 17:40
@xmnlab
Copy link
Member Author

xmnlab commented Apr 24, 2024

@fccoelho the unit tests on CI is silently failing:

=========================== short test summary info ============================
FAILED tests/test_analysis/test_ngboost_models.py::test_rolling_predictions - TypeError: interval() got an unexpected keyword argument 'alpha'
FAILED tests/test_analysis/test_ngboost_models.py::test_rolling_forecast - TypeError: interval() got an unexpected keyword argument 'alpha'
FAILED tests/test_data/test_foph.py::test_downloading_daily_csv_cases - pandas.errors.EmptyDataError: No columns to parse from file
FAILED tests/test_data/test_foph.py::test_downloading_weekly_csv_default_cases - pandas.errors.EmptyDataError: No columns to parse from file
FAILED tests/test_data/test_foph.py::test_downloading_weekly_csv_by_age_cases - pandas.errors.EmptyDataError: No columns to parse from file
FAILED tests/test_data/test_foph.py::test_downloading_weekly_csv_by_sex_cases - pandas.errors.EmptyDataError: No columns to parse from file
===== 6 failed, 38 passed, 17 skipped, 3973 warnings in 197.93s (0:03:17) ======

I am not sure about the error about the interval ... I tried to find the interval function in scikit learn and ngboos .. but I didn't have any success.

let me know if it would be ok to move forward with this PR or if you want any change.

@xmnlab
Copy link
Member Author

xmnlab commented May 6, 2024

@fccoelho , a friendly reminder about this PR, thanks!

Copy link
Contributor

@fccoelho fccoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xmnlab
Copy link
Member Author

xmnlab commented May 6, 2024

thanks for the review @fccoelho

@xmnlab xmnlab merged commit cccd400 into thegraphnetwork:main May 6, 2024
1 check passed
@xmnlab xmnlab deleted the fix-depds branch May 6, 2024 19:24
Copy link

github-actions bot commented May 6, 2024

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants