-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the use of Mermaidjs for diagrams, and demonstrate it in our deploy docs #320
Changes from all commits
e4fec1b
ed3e8b5
82b57a6
54663e2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -154,3 +154,6 @@ staticfiles | |
RELEASE | ||
|
||
.*venv | ||
|
||
# do not track generated docs | ||
_build |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ | |
# Add any Sphinx extension module names here, as strings. They can be | ||
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom | ||
# ones. | ||
extensions = ["myst_parser"] | ||
extensions = ["myst_parser", "sphinxcontrib.mermaid"] | ||
|
||
# Add any paths that contain templates here, relative to this directory. | ||
templates_path = ["_templates"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @mrchrisadams! As a small comment I would suggest - and I think you might agree and like this - to add a theme. As of now it still looks a bit dull with the default option, but it seems that Mermaid allows for multiple themes (including a green one!). Check this out:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh neat, I didn't know mermaid did themes! I'll have a quick look - if it's not much more work, and sphinx supports it I'll try adding it, otherwise I'll make a separate issue, as the functionality of having diagrams was the key idea. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hmm… this looks a bit more complicated than I thought, @roald-teunissen. I'd prefer to merge this in and pick up this work another time. The issue for it is below. |
||
|
@@ -51,4 +51,3 @@ | |
# relative to this directory. They are copied after the builtin static files, | ||
# so a file named "default.css" will overwrite the builtin "default.css". | ||
html_static_path = ["_static"] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
-i https://pypi.org/simple | ||
myst-parser==0.18.0 | ||
furo==2022.6.21 | ||
sphinxcontrib-mermaid==0.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a new version of sqlalchemy out, that breaks things. We pin the pipfile to avoid this heartache