Merge pull request #1474 from thehyve/multi-model-views

Fix linter warnings on exhaustive-deps.
thehyve · Jan 25, 2024 · 4255407 · 4255407
2 parents 6797bc1 + c0f1f1d
commit 4255407
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/projects/mercury/src/constants.js b/projects/mercury/src/constants.js
@@ -1,4 +1,5 @@
 export const APPLICATION_NAME = 'Fairspace';
+export const METADATA_VIEW_MENU_LABEL = 'Metadata';
 export const LOCAL_STORAGE_MENU_KEY = 'FAIRSPACE_MENU_EXPANDED';
 export const CUT = 'CUT';
 export const COPY = 'COPY';

diff --git a/projects/mercury/src/metadata/LinkedDataMetadataProvider.js b/projects/mercury/src/metadata/LinkedDataMetadataProvider.js
@@ -18,11 +18,14 @@ const LinkedDataMetadataProvider = ({children, ...otherProps}) => {
     const fetchMetadataBySubject = useCallback((subject) => metadataAPI.getDict({subject, withValueProperties: true})
         .catch(() => {
             throw new Error('An error occurred while loading the metadata');
+            // eslint-disable-next-line react-hooks/exhaustive-deps
         }), []);
 
     const submitLinkedDataChanges = useCallback((subject, values) => metadataAPI.get({subject})
         .then(meta => (meta.length && getFirstPredicateValue(meta[0], '@type')))
-        .then(type => metadataAPI.updateEntity(subject, values, vocabulary, type)), [vocabulary]);
+        .then(type => metadataAPI.updateEntity(subject, values, vocabulary, type)),
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [vocabulary]);
 
     const createLinkedDataEntity = useCallback((subject, values, type) => metadataAPI.get({subject})
         .then((meta) => {
@@ -31,7 +34,9 @@ const LinkedDataMetadataProvider = ({children, ...otherProps}) => {
             }
         })
         .then(() => metadataAPI.updateEntity(subject, values, vocabulary, type))
-        .then(() => ({subject, type, values})), [vocabulary]);
+        .then(() => ({subject, type, values})),
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [vocabulary]);
 
     const deleteLinkedDataEntity = (subject) => metadataAPI.delete(subject);
 

diff --git a/projects/mercury/src/routes/WorkspaceRoutes.js b/projects/mercury/src/routes/WorkspaceRoutes.js
@@ -17,6 +17,7 @@ import MetadataView from '../metadata/views/MetadataView';
 import BreadcrumbsContext from '../common/contexts/BreadcrumbsContext';
 import {ExternalStoragePage} from "../external-storage/ExternalStoragePage";
 import ExternalMetadataSourcesView from "../metadata/external-sources/ExternalMetadataSourceView";
+import {METADATA_VIEW_MENU_LABEL} from "../constants";
 
 const getSubject = () => (
     document.location.search ? queryString.parse(document.location.search).iri : null
@@ -105,7 +106,7 @@ const WorkspaceRoutes = () => {
                     if (subject) {
                         return (
                             <MetadataWrapper>
-                                <LinkedDataEntityPage title="Metadata" subject={subject} />
+                                <LinkedDataEntityPage title={METADATA_VIEW_MENU_LABEL} subject={subject} />
                             </MetadataWrapper>
                         );
                     }