Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numeric facet slider tooltip. #1523

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

ewelinagr
Copy link
Member

@ewelinagr ewelinagr commented May 23, 2024

Fixes FAIRSPC-9

@ewelinagr ewelinagr requested a review from tgreenwood May 23, 2024 09:01
@tgreenwood
Copy link
Contributor

That's impressive how quickly you fixed that! The only moment I found is that the tooltip is not shown until you change the pre-set long value

image

@ewelinagr
Copy link
Member Author

The only moment I found is that the tooltip is not shown until you change the pre-set long value

@tgreenwood It is fixed now - if no value is specified, the tooltip will show the placeholder value

@ewelinagr ewelinagr added the bugfix Pull request that fixes a bug label May 23, 2024
@tgreenwood
Copy link
Contributor

All is good, I am just thinking about one more tiny point
image

now the tooltip is available like every time user hovers cursor over the edit field, even when there is no need for that (small numbers). Is it something we could hide while no need to duplicate the info for users to make it visible? I would also understand, if you called my comment "an overhead' :)

@ewelinagr
Copy link
Member Author

now the tooltip is available like every time user hovers cursor over the edit field, even when there is no need for that (small numbers). Is it something we could hide while no need to duplicate the info for users to make it visible? I would also understand, if you called my comment "an overhead' :)

hmm, not sure how to do that 😅 Depending on things like screen resolution, zoom etc the number of digits would be different... Not sure if having the tooltip always there would be now considered annoying

@tgreenwood
Copy link
Contributor

never

now the tooltip is available like every time user hovers cursor over the edit field, even when there is no need for that (small numbers). Is it something we could hide while no need to duplicate the info for users to make it visible? I would also understand, if you called my comment "an overhead' :)

hmm, not sure how to do that 😅 Depending on things like screen resolution, zoom etc the number of digits would be different... Not sure if having the tooltip always there would be now considered annoying

nevermind then, let's have it as is

@ewelinagr ewelinagr merged commit 1a30c41 into dev May 27, 2024
6 checks passed
@ewelinagr ewelinagr deleted the FAIRSPC-9_fix-numeric-faced-slider branch May 27, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants