FAIRSPC-68: fixed date filter for Jena #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgreenwood
force-pushed
the
bugfix/FAIRSPC-68
branch
3 times, most recently
from
0eeca54 to
834904c
Compare
ewelinagr
reviewed
May 27, 2024
| case Date -> makeDateTime(convertDateValue(o.toString())); | ||
| // Extract date only as it comes in format "yyyy-MM-dd'T'HH:mm:ss.SSSX" | ||
| // Leave it as is in case of adding new DateTime filter format | ||
| case Date -> makeDate(o.toString().split("T")[0]); |
There was a problem hiding this comment.
I haven't tested it, but wouldn't it leave yyyy-MM-dd' after the split (with an apostrophe ' at the end)?
But it looks like the format that it actually comes in is without ' ' around T, right?
There was a problem hiding this comment.
It's confusing, agree. I removed the quotes in the comment as request does not contain them. It was an unlucky attempt to highlight
tgreenwood
force-pushed
the
bugfix/FAIRSPC-68
branch
from
834904c to
70357bd
Compare
ewelinagr
approved these changes
May 28, 2024
frankyhollywood
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugfix found on a datamodel where we define some attributes as date fields. The whole application operates with datetime format (front-end with its Date type, back-end with Instant/timestamp for Postrgres) while in Jena we use date format. But all mappings for Jena map data type to date time. It wouldn't be an easy way to switch to pure date format everywhere (especially because we do not support data model evolution within data model versioning).
I suggest then just to add handling datetime for Jena in one place instead of reworking it in multiple places with un-answered question about how easily to deploy it to already existing environments with datetime formats.