Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MerlinMagic] Fixed output for crypto snippy_variants_num_variants #654

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

Michal-Babins
Copy link
Contributor

@Michal-Babins Michal-Babins commented Oct 18, 2024

This PR closes #653

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

Fixed snippy_variants_num_variants output for snippy_crypto, changing the ouput correctly to snippy_crypto.snippy_variants_num_variants

⚡ Impacted Workflows/Tasks

  • wf_merlin_magic

This PR may lead to different results in pre-existing outputs: Yes

This PR uses an element that could cause duplicate runs to have different results: No

🛠️ Changes

Changed output block in wf_merlin_magic:snippy_variants_num_variants from snippy_crypto.snippy_variants_num_reads_aligned to snippy_crypto.snippy_variants_num_variants

⚙️ Algorithm

➡️ Inputs

⬅️ Outputs

wf_merlin_magic:snippy_variants_num_variants changed from snippy_crypto.snippy_variants_num_reads_aligned to snippy_crypto.snippy_variants_num_variants

🧪 Testing

Light testing to confirm the output done here

Suggested Scenarios for Reviewer to Test

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable (Theiagen developers only)

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@Michal-Babins Michal-Babins marked this pull request as ready for review October 21, 2024 19:38
@Michal-Babins Michal-Babins requested a review from a team as a code owner October 21, 2024 19:38
Copy link
Member

@sage-wright sage-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good; running on the current release here to confirm that the changes that were made are accurate

Copy link
Member

@sage-wright sage-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@sage-wright sage-wright merged commit 757f316 into main Oct 22, 2024
7 checks passed
@sage-wright sage-wright deleted the mb-crypto-output-fix branch October 22, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Merlin Magic] Incorrectly Declared Output for Snippy Variants
2 participants