Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] type error correction theiacov wf #660

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

fraser-combe
Copy link
Contributor

@fraser-combe fraser-combe commented Oct 24, 2024

πŸ—‘οΈ This dev branch should be deleted after merging to main.

🧠 Summary

This is just a type correction on the variable input_assembly_method from File to String no other changes

πŸ”¬ Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable (Theiagen developers only)

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@fraser-combe fraser-combe requested a review from a team as a code owner October 24, 2024 13:27
@fraser-combe fraser-combe changed the title type error correction theiacov wf [Documentation] type error correction theiacov wf Oct 24, 2024
Copy link
Contributor

@AndrewLangvt AndrewLangvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix on the type error @fraser-combe

@AndrewLangvt AndrewLangvt merged commit d4f3da8 into main Oct 24, 2024
3 checks passed
@AndrewLangvt AndrewLangvt deleted the fc-type-fixtheiacov-dev branch October 24, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants