Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheiaCoV] Update nextclade dataset tag for H5N1 to the latest version #683

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Michal-Babins
Copy link
Contributor

@Michal-Babins Michal-Babins commented Dec 4, 2024

This PR closes #682

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

Updates wf_organism_paramters ds tag for H5N1 HA segment

⚡ Impacted Workflows/Tasks

wf_organism_paramters
This PR may lead to different results in pre-existing outputs: No

This PR uses an element that could cause duplicate runs to have different results: No

🛠️ Changes

h5n1_ha_nextclade_ds_tag changed from old 2024-05-08--11-39-52Z ds tag to new 2024-12-04--17-05-31Z tag.

⚙️ Algorithm

h5n1_ha_nextclade_ds_tag version bump for nextclade.

➡️ Inputs

⬅️ Outputs

🧪 Testing

Tested specifically on h5n1 flu data here
-This output of this will show the 2024-12-04--17-05-31Z ds tag as well as NA segment being correctly identified.

Tested illumina_pe validation set here

Suggested Scenarios for Reviewer to Test

Please repeat this test here and check the nextclade tags. Feel free to test any other data set. The h5n1 data I was able to find was PE.

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable (Theiagen developers only)

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@Michal-Babins Michal-Babins marked this pull request as ready for review December 4, 2024 22:42
@Michal-Babins Michal-Babins requested a review from a team as a code owner December 4, 2024 22:42
Copy link
Member

@sage-wright sage-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sage-wright sage-wright merged commit 145188b into main Dec 6, 2024
13 checks passed
@sage-wright sage-wright deleted the mb-nextclade-h5nx-updates branch December 6, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TheiaCoV] Add updated H5Nx nextclade before next release.
2 participants