-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Augur] Expose Augur versions #686
Conversation
…tory for iqtree model extraction
…titution model and rename iqtree model variable for clarity
…D file is supplied by user for masking. also added DEBUG echo statement to see model string printed to log file. tested successfully w miniwdl both with and without BED file supplied and "auto" used as substitution_model input string
…rings for mafft version and iqtree version. added these 2 output strings to Augur workflow
… -euo pipefail. tested successfully w miniwdl
…d thus 2 new String outputs. tested all 3 w miniwdl. Also updated augur wf to output these strings
For clarity - This PR adds the ability to capture the model used in the rare scenario that the user provides a BED file to Want to also note that this PR adds And lastly, we added Here are links to my tests in Terra:
I'm going to launch one more test with a BED file used as input for the augur_tree task, just to ensure iqtree version and model output strings are still present |
last test. Ran successfully ✅ and produced the Don't forget about updating the Augur docs for these new output strings |
I tested the following above to confirm:
Documentation also updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for running those tests and updating the docs, much appreciated! Nice work on this PR 👍
CC @sage-wright I believe it's ready for merging
# capture version information | ||
augur version > VERSION | ||
echo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you've got an extra echo here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah i see you're using them as line breaks in the output log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
This PR closes #685
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
This PR captures versions for iqtree, fasttree, raxml, and version of iqtree model being used with Augur.
⚡ Impacted Workflows/Tasks
wf_augur
task_augur_tree
This PR may lead to different results in pre-existing outputs: No
This PR uses an element that could cause duplicate runs to have different results: No
🛠️ Changes
Outputs have been added to capture the following version outputs for
augur
:Where
iqtree_model_used
is for the actual iqtree model and not iqtree software version which is captured iniqtree_version
.⚙️ Algorithm
In
task_augur_tree
, now depending on whatmethod
is chosen (iqtree,fasttree,raxml) that sofware version will be captured in the output.➡️ Inputs
⬅️ Outputs
The following output has been added to
task_augur_tree
:The following outputs have been added top level to
wf_augur
:🧪 Testing
Suggested Scenarios for Reviewer to Test
🔬 Final Developer Checklist
🎯 Reviewer Checklist