-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RASUSA] update from 0.7.0 -> 2.1.0 #731
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sage-wright
requested changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor documentation updates needed, code changes look good so far! will test shortly
sage-wright
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look good and reads are being downsampled 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #461 and updates RASUSA container and documentation references to v2.1.0. Issue #461 references v2.0.0, though this PR advances to v2.1.0 as the most recent stable update hosted on StaPH-B.
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
Copy StaPH-B RASUSA v2.1.0 container to Theiagen artifacts repository, update container in
task_rasusa.wdl
and downstream workflows, modifytask_rasusa.wdl
execution of RASUSA to conform to RASUSA's new subcommand and argument formatting, and update documentation to reference new container version.⚡ Impacted Workflows/Tasks
Immediate impacts:
task_rasusa.wdl
wf_rasusa.wdl
Immediate Downstream impacts:
wf_read_QC_trim_ONT.wdl
wf_theiaprok_ont.wdl
task_broad_terra_tools.wdl
wf_theiaeuk_illumina_pe.wdl
This PR may lead to different results in pre-existing outputs: Yes/No
No
This PR uses an element that could cause duplicate runs to have different results: Yes/No
This PR does not change the state of RASUSA output compared to previous versions, though RASUSA inherently produces different results due to random sampling in its algorithm.
🛠️ Changes
See Algorithm
⚙️ Algorithm
(
task_rasusa.wdl
)set -euo pipefail
-o
for each output file detected to conform to rasusa update➡️ Inputs
No input changes at the task / workflow level
⬅️ Outputs
No output changes
🧪 Testing
Suggested Scenarios for Reviewer to Test
Initial testing covers most usage scenarios
🔬 Final Developer Checklist
workflows_overview
tables to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"🎯 Reviewer Checklist