[Taxon_Tables] Synchronize task_broad_terra_tools.wdl with current workflow outputs #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #444
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
⚡ Impacted Workflows/Tasks
task_broad_terra_tools.wdl
wf_theiaprok_fasta.wdl
wf_theiaprok_illumina_se.wdl
wf_theiaprok_illumina_pe.wdl
wf_theiaprok_ont.wdl
This PR may lead to different results in pre-existing outputs: Yes (table outputs are modified) !!! THIS WILL MAKE PREVIOUS TAXON TABLES GENERATED BY EARLIER VERSIONS INCOMPATIBLE WITH CONCATENATION DUE TO DISCREPANT COLUMN NAMING !!!
This PR uses an element that could cause duplicate runs to have different results: No
🛠️ Changes
task_broad_terra_tools.wdl
to synchronize with downstream Theia-level workflowstask_broad_terra_tools.wdl
, dependencies' calls, and documentationNOTE: This update ensures
task_broad_terra_tools.wdl
ONLY accepts inputs that exactly match downstream dependencies' inputs or outputs. This means that any Theia- workflow that previously passed an output totask_broad_terra_tools.wdl
that wasn't exposed to the Theia-workflow outputs is removed fromtask_broad_terra_tools.wdl
. e.g.genotyphi_genotype_confidence = merlin_magic.genotyphi_genotype_confidence
was removed fromwf_theiaprok_fasta.wdl
's call.Some inputs into the
terra_tools.export_taxon_tables
call have simply changed names to correspond with the workflow's variable naming.⚙️ Algorithm
Modified the outputs in the table generated by
task_broad_terra_tools.wdl
and adjusted its I/O to accommodate downstream workflows' outputs.➡️ Inputs
Please refer to the Files Changed - all I/O changes are to
task_broad_terra_tools.wdl
andexport_taxon_tables
calls in downstream workflows⬅️ Outputs
Please refer to the Files Changed - all I/O changes are to
task_broad_terra_tools.wdl
andexport_taxon_tables
calls in downstream workflows🧪 Testing
Suggested Scenarios for Reviewer to Test
n/a - Recommended line-by-line review of removed and newly exposed I/O to ensure desired function is implemented
🔬 Final Developer Checklist
workflows_overview
tables to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"🎯 Reviewer Checklist