-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Freyja] Expose additional outputs and parse demixed output file for easy downstream concatenation #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few documentation and style changes requested.
testing here
outputs on terra look good! ⭐ once those changes are in and i run a verification test i'll merge! |
…on that the entry exists!
final confirmation test here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ fabulous
This PR closes #
🗑️ This dev branch should be deleted after merging to main.
🧠 Summary
This PR exposes several new outputs from Freyja parsed from the
freyja_demixed.tsv
output file, namely:Additionally, the
freyja_demixed.tsv
output file is wrangled intofreyja_demixed_parsed
file for easy downstream concatenation, resulting in a new output file:This file looks like this:
⚡ Impacted Workflows/Tasks
This PR may lead to different results in pre-existing outputs: No
This PR uses an element that could cause duplicate runs to have different results: No
🛠️ Changes
⚙️ Algorithm
The python block has been expanded to expose the new outputs and perform file wrangling with pandas to create the new parsed demixed file.
➡️ Inputs
Nothing changed
⬅️ Outputs
New outputs:
🧪 Testing
Local testing of task:
miniwdl run --task freyja_one_sample /home/ines_mendes/Git/public_health_bioinformatics/tasks/taxon_id/freyja/task_freyja.wdl samplename="PTB" primer_trimmed_bam= PTB.primertrim.sorted.bam reference_genome= nCoV-2019.reference.fasta
Test on Terra:

https://app.terra.bio/#workspaces/theiagen-validations/Theiagen_Mendes_Sandbox/job_history/8cf1e2b6-5fc9-40af-a0c2-19c78b967ea7
Suggested Scenarios for Reviewer to Test
Test Freyja on an alternative organism! Only tested on SC2.
🔬 Final Developer Checklist
workflows_overview
tables to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"🎯 Reviewer Checklist