Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TheiaProk] improve export taxon table functionality #757

Merged
merged 11 commits into from
Feb 18, 2025

Conversation

sage-wright
Copy link
Member

@sage-wright sage-wright commented Feb 13, 2025

This PR closes #444

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

drastically reduce maintenance burden for export_taxon_table functionality
drastically reduce number of undesired optional inputs in terra for all theiaprok workflows

⚡ Impacted Workflows/Tasks

all theiaprok

This PR may lead to different results in pre-existing outputs: No

This PR uses an element that could cause duplicate runs to have different results: No

🛠️ Changes

i'm using a map to pass in the data and then parsing that map w/o hard-coding the various data so it's dope

⚙️ Algorithm

➡️ Inputs

lol all export_taxon_table inputs are now gone from terra except cpu, docker, disk_size, and memory as it should be

⬅️ Outputs

Nope

🧪 Testing

TheiaProk_FASTA - on full PE dataset except for samples w/o assemblies
TheiaProk_Illumina_PE - one of every species in the dataset
TheiaProk_Illumina_SE - on full SE dataset
TheiaProk_ONT - all data from dataset with read1

Suggested Scenarios for Reviewer to Test

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable
    • You have updated the "Last Known Changes" field for any affected workflows in the respective workflow documentation page and for every entry in the three workflows_overview tables to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@sage-wright sage-wright marked this pull request as ready for review February 14, 2025 20:29
@sage-wright sage-wright requested a review from a team as a code owner February 14, 2025 20:29
@xonq
Copy link
Member

xonq commented Feb 18, 2025

Copy link
Contributor

@Michal-Babins Michal-Babins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zach reviewed and tested the changes. I went through and confirmed Zach's test. Code changes and tests are good. Next step is for Zach to update his python script to serialize the wdl map of exon inputs.

@Michal-Babins Michal-Babins merged commit 0165272 into main Feb 18, 2025
11 checks passed
@Michal-Babins Michal-Babins deleted the smw-taxon-test-dev branch February 18, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[taxon table] update the taxon tables to match workflow outputs
3 participants