Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Taxon_Table] resync taxon_tables inputs #762

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

xonq
Copy link
Member

@xonq xonq commented Feb 19, 2025

🗑️ This dev branch should be deleted after merging to main.

🧠 Summary

Resyncs inputs in export_taxon_table calls in all theiaprok workflows

⚡ Impacted Workflows/Tasks

wf_theiaprok_illumina_se.wdl
wf_theiaprok_illumina_pe.wdl
wf_theiaprok_ont.wdl
wf_theiaprok_fasta.wdl

This PR may lead to different results in pre-existing outputs: Yes

This PR uses an element that could cause duplicate runs to have different results: No

🛠️ Changes

Add and remove inputs to export_taxon_table calls to synchronize with workflow outputs.

⚙️ Algorithm

n/a

➡️ Inputs

Please see files changed

⬅️ Outputs

n/a

🧪 Testing

Suggested Scenarios for Reviewer to Test

n/a

🔬 Final Developer Checklist

  • The workflow/task has been tested and results, including file contents, are as anticipated
  • The CI/CD has been adjusted and tests are passing (Theiagen developers)
  • Code changes follow the style guide
  • Documentation and/or workflow diagrams have been updated if applicable
    • You have updated the "Last Known Changes" field for any affected workflows in the respective workflow documentation page and for every entry in the three workflows_overview tables to be the tag for the next upcoming release. If you do not know the tag, please put "vX.X.X"

🎯 Reviewer Checklist

  • All changed results have been confirmed
  • You have tested the PR appropriately (see the testing guide for more information)
  • All code adheres to the style guide
  • MD5 sums have been updated
  • The PR author has addressed all comments
  • The documentation has been updated

@xonq xonq marked this pull request as ready for review February 19, 2025 22:42
@xonq xonq requested a review from a team as a code owner February 19, 2025 22:42
Copy link
Contributor

@Michal-Babins Michal-Babins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script was able to identify changes and Zach changed per differences in expected I/O's.

@Michal-Babins Michal-Babins merged commit 45da003 into main Feb 20, 2025
10 checks passed
@Michal-Babins Michal-Babins deleted the kzm-export_taxon_tables-dev branch February 20, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants