Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recently added support for symlinks #475

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Remove recently added support for symlinks #475

merged 1 commit into from
Nov 6, 2024

Conversation

andy5995
Copy link
Member

@andy5995 andy5995 commented Nov 6, 2024

This partially reverts #462

@andy5995 andy5995 added this to the v0.9.3 milestone Nov 6, 2024
@andy5995 andy5995 merged commit 52d7f75 into master Nov 6, 2024
18 checks passed
@andy5995 andy5995 deleted the no_symlinks branch November 6, 2024 04:28
@ccoVeille
Copy link
Collaborator

Any explanation that would come with the PR?

@andy5995
Copy link
Member Author

andy5995 commented Nov 6, 2024

@ccoVeille This just means that any waste folder folder defined in your config file must not be a symbolic link. In the future, any waste folder defined using a symlink will be ignored and not used.

@andy5995
Copy link
Member Author

andy5995 commented Nov 6, 2024

The trash spec mentions symbolic links only once:

When trashing a file from a non-home partition/device [4] , an implementation (if it supports trashing in top directories) MUST check for the presence of $topdir/.Trash.

When preparing a list of all trashed files (for example, to show to the user), an implementation also MUST check for .Trash in all top directories that are known to it.

If this directory is present, the implementation MUST, by default, check for the “sticky bit”. (It MAY provide a way for the administrator, and only the administrator, to disable this checking for a particular top directory, in order to support file systems that do not have the “sticky bit”).

The implementation also MUST check that this directory is not a symbolic link.

I'm a bit confused by it. But I don't see why anyone would need a symbolic link. They can just define directory the symlink points to. For other desktop trash systems where trash dirs can't be defined, I see where it might be useful. Like in the case where @luigir-it has a symlink to their btrfs subvolume. But with rmw, they can just put the actual directory in the rmw config file.

@ccoVeille
Copy link
Collaborator

Thanks it's clearer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants