Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-751] fix canary deployment #295

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

ghkadim
Copy link
Collaborator

@ghkadim ghkadim commented Feb 7, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (documentation addition or typo, file relocation)

Testing

  • New tests were added with this PR that prove my fix is effective or that my feature works (describe below this bullet)
  • This change requires no testing (i.e. documentation update)

Documentation

  • All added public packages, funcs, and types have been documented with doc comments
  • I have commented my code, particularly in hard-to-understand areas

Final Checklist:

  • I followed standard GitHub flow guidelines
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Additional Information (omit if empty)

Please include anything else relevant to this PR that may be useful to know.

@ghkadim ghkadim force-pushed the PLAY-751-validate-canary-deployment branch from 3b70ddb to 2883009 Compare February 7, 2024 12:36
@ghkadim ghkadim force-pushed the PLAY-751-validate-canary-deployment branch from 2883009 to 05a0477 Compare February 7, 2024 13:15
@ghkadim ghkadim marked this pull request as ready for review February 7, 2024 13:37
@ghkadim ghkadim requested review from koncar and fnovikov February 7, 2024 13:37
@ghkadim ghkadim merged commit 4ca8b68 into main Feb 9, 2024
6 checks passed
@ghkadim ghkadim deleted the PLAY-751-validate-canary-deployment branch February 9, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants