Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed so glob does not follow symlinks. #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanFlor
Copy link

@DanFlor DanFlor commented Mar 19, 2019

Circular symlinks in modules were breaking the script.

Description of changes

Changed the glob call in utilities.js to not follow symlinks. See issue #66 for details.

Related issues (if any)

#66

@thekevinbrown
Copy link
Owner

@DanFlor, thanks for the contribution. I think the use case that necessitated following symlinks was when people use npm link to bring a module in for development, which we still wanted to modify the .xcodeproj for.

I think it's probably a bit of an edge case, given that the React project is the one we're really after, so I'm open to merging this change, but I'd recommend changing it from { follow: false } to just omitting the options object, as that's the default behaviour of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants