refactor installer using getInstallPath method

thelia · Sep 1, 2014 · 7926e18 · 7926e18
1 parent 6b3f1ae
commit 7926e18
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 21 deletions.
diff --git a/src/Thelia/Composer/TheliaInstaller.php b/src/Thelia/Composer/TheliaInstaller.php
@@ -15,7 +15,6 @@
 use Composer\Installer\LibraryInstaller;
 use Composer\Package\PackageInterface;
 
-
 /**
  * Class TheliaInstaller
  * @package Thelia\Composer
@@ -24,34 +23,42 @@
 class TheliaInstaller extends LibraryInstaller
 {
     protected $locations = [
-        'module' => 'local/modules/{$name}/',
-        'frontoffice-template' => 'templates/frontOffice/{$name}/',
-        'backoffice-template' => 'templates/backOffice/{$name}/',
-        'email-template' => 'templates/email/{$name}/',
-    ];
-
-    protected $supportedType = [
-        'thelia-module',
-        'thelia-frontoffice-template',
-        'thelia-backoffice-template',
-        'thelia-email-template'
+        'thelia-module' => 'local/modules/',
+        'thelia-frontoffice-template' => 'templates/frontOffice/',
+        'thelia-backoffice-template' => 'templates/backOffice/',
+        'thelia-email-template' => 'templates/email/',
     ];
 
-    /**
-     * {@inheritDoc}
-     */
-    public function getPackageBasePath(PackageInterface $package)
+    public function getInstallPath(PackageInterface $package)
     {
+        $type = $package->getType();
+        if (!isset($this->locations[$package->getType()])) {
+            throw new \InvalidArgumentException(sprintf('package type "%s" is not supported', $type));
+        }
+
+        $base = $this->locations[$type];
+
+        $prettyName = $package->getPrettyName();
+        if (strpos($prettyName, '/') !== false) {
+            list($vendor, $name) = explode('/', $prettyName);
+        } else {
+            $vendor = '';
+            $name = $prettyName;
+        }
 
-        return $this->locations[$package->getType()] . $package->getPrettyName();
+        $extra = $package->getExtra();
+        if (!empty($extra['installer-name'])) {
+            $name = $extra['installer-name'];
+        }
 
+        return $base . $name;
     }
 
     /**
      * {@inheritDoc}
      */
     public function supports($packageType)
     {
-        return in_array($packageType, $this->supportedType);
+        return array_key_exists($packageType, $this->locations);
     }
-} 
+}
diff --git a/src/Thelia/Composer/TheliaInstallerPlugin.php b/src/Thelia/Composer/TheliaInstallerPlugin.php
@@ -12,7 +12,6 @@
 
 namespace Thelia\Composer;
 
-
 use Composer\Composer;
 use Composer\IO\IOInterface;
 use Composer\Plugin\PluginInterface;
@@ -28,4 +27,4 @@ public function activate(Composer $composer, IOInterface $io)
         $installer = new TheliaInstaller($io, $composer);
         $composer->getInstallationManager()->addInstaller($installer);
     }
-} 
+}