Add an upgrade guide and extract abbreviations into a shared file #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e breaking changes, fix info about log timzeone
astorije
commented
Nov 3, 2018
| @@ -18,4 +18,4 @@ The Lounge started as a fork of [Shout](https://github.com/erming/shout), author | |||
|
|
|||
| Enjoy The Lounge, and make sure to join us on our **official Freenode channel `#thelounge`**! | |||
|
|
|||
| *[IRC]: Internet Relay Chat | |||
| {% include abbreviations.md %} | |||
There was a problem hiding this comment.
I couldn't find a better way to make this a thing in all files for a given layout or whatnot, so until something arises, this is better than nothing I think.
xPaw
reviewed
Nov 3, 2018
_guides/upgrade.md
Outdated
| ## TL;DR | ||
|
|
||
| - You need Node.js v6.13.0 or more recent. | ||
| - Everything called `[something]lounge[something]` becomes `[something]thelounge[something]`. |
There was a problem hiding this comment.
I still think [something] is confusing to read here. Maybe just expand it to describe the command and folder separately?
There was a problem hiding this comment.
Agreed re: confusing. Will reword.
xPaw
approved these changes
Nov 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #84.