Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categories to mark active in menu correctly #158

Closed
wants to merge 1 commit into from

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Nov 5, 2018

Fixes #156

@xPaw xPaw requested a review from astorije November 5, 2018 09:57
@xPaw xPaw force-pushed the xpaw/active-menu-category branch from 1ea5f90 to 7103005 Compare November 5, 2018 11:16
@astorije
Copy link
Member

astorije commented Nov 6, 2018

I would love to not reintroduce the category keyword in the front matter for this really, as it's cumbersome and error-prone.
I was about to do it using URL prefix because really it makes sense, if you're under /docs/guides/foo and you go back to docs/guides you should go to the parent page. Mind doing that instead?

I'm aware that this won't work for the unofficial install methods method and hmm... I'm not too offended by this one not marking the install page as active really. For one thing, it's the only page in there, and... I have suggested to kill it in a couple places 😬

@xPaw
Copy link
Member Author

xPaw commented Nov 6, 2018

I tried the URL, but it uses the folder name, so it doesn't match, unsure if there's another method

@xPaw xPaw closed this Nov 6, 2018
@xPaw xPaw deleted the xpaw/active-menu-category branch November 6, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants