-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d6a195f
commit 99de837
Showing
2 changed files
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99de837
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themashcodee I'll admit I don't love this solution. The hardcoded
"fallback"
is a bit hacky. Here are some suggestions for other methods to achieve this:fallback
argument which is a function(name:string) => ReactNode
, which the caller has the option to use as needed. This function is the default behavior for the hook.null
indicates failure and should rely on the default behavior. Returning""
empty string means the caller does not want to show anything for the emoji.Personally, I prefer #1. What do you think?
99de837
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StephenTangCook resolved in v0.3.10