Bump versions of CPython, PyPy, and Tox #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@themattrix Would you mind merging? @moreati The list of Pythons would now need to be extended by Python 3.9.1 (reported also via themattrix/docker-tox#22), and Tox should be updated to the latest stable version (currently 3.20.1). Do you want to update your PR before it gets merged? |
|
@moreati To save you the time-consuming research, here is a diff of the changes I found necessary: diff --git a/Dockerfile b/Dockerfile
index b4cad03..610b2c1 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -23,7 +23,7 @@ RUN set -x && \
RUN pyenv local 3.7.5 && \
python -m pip install -U pip && \
- python -m pip install tox==3.14.0 && \
+ python -m pip install tox==3.20.1 && \
pyenv local --unset && \
pyenv rehash
diff --git a/README.md b/README.md
index dea4d22..0b81831 100644
--- a/README.md
+++ b/README.md
@@ -1,4 +1,4 @@
# Tox-Base
-This image contains Python versions 2.6, 2.7, 3.4, 3.5, 3.6, 3.7, 3.8, PyPy, and PyPy3.
+This image contains Python versions 2.6, 2.7, 3.4, 3.5, 3.6, 3.7, 3.8, 3.9, PyPy, and PyPy3.
It also includes [tox](https://pypi.python.org/pypi/tox) for running test automation against the various versions.
diff --git a/python-versions.txt b/python-versions.txt
index f075034..2774d70 100644
--- a/python-versions.txt
+++ b/python-versions.txt
@@ -1,11 +1,11 @@
-3.8.0
-3.7.5
-3.6.9
-3.5.7
+3.9.1
+3.8.6
+3.7.9
+3.6.12
+3.5.10
3.4.10
3.3.7
-2.7.17
+2.7.18
2.6.9
-pypy2.7-7.2.0
-pypy3.6-7.2.0
-pypy3.3-5.5-alpha
+pypy2.7-7.3.1
+pypy3.6-7.3.1A newer version of Python 3.8 exists, but it's not yet included in pyenv. The patch above also removes |
|
ping 🔔 @moreati Please update the PR. |
|
on it
…On Fri, 22 Jan 2021 at 07:26, Peter Bittner ***@***.***> wrote:
*ping* 🔔
@moreati <https://github.com/moreati> Please update the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABKS4RXYVGZVJHMFAF62DDS3ESARANCNFSM4KZU2O5Q>
.
--
Alex Willmer <[email protected]>
|
|
Feel free to squash, or I can do so if desired. docker build run |
|
@themattrix Can you please merge this PR? |
bittner
reviewed
Feb 3, 2021
Comment on lines
+24
to
+25
| ENV TOX_PYTHON_VERSION 3.9.1 | ||
| ENV TOX_VERSION 3.21.2 |
There was a problem hiding this comment.
Shouldn't those better be build ARGs with a default value instead of plain environment variables?
|
@themattrix would be nice if we would be able to use python 3.9. Thanks for the project! |
|
I tried to ping @themattrix on LinkedIn, too, and on Twitter. Maybe he doesn't receive any notifications. 🤔 💭 🕦 Good catch @Pils19! 😆 |
|
@themattrix Matthew, please merge this PR! We do depend on this software to be maintained. |
|
@themattrix Any hope that this ever gets merged? – We even need Python 3.10 too now. 😟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left tox installed in the CPython 3.7.x pyenv, instead of installing it under 3.8.x. I wasn't sure if you had a spcific reason for using that minor release still.