Skip to content
This repository has been archived by the owner on Nov 9, 2024. It is now read-only.

Add „Tested up to“ and „Required PHP“, update tags #31

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

krafit
Copy link
Member

@krafit krafit commented Jan 9, 2021

Fixes a couple of issues, described in #19.

I added the required information regarding the minimum supported WP and PHP version and tested WP version.
Regarding those values: 4.4 is the oldest version I was able to test Popper with, might work on older versions as well, I didn't deem it important enough to further inspect this, since the market share <4.9 is rather small.
Similar to a recent discussion regarding Antispam Bees min PHP version, 5.6 seems like the sensible option here.

The two removed tags are considered as deprecated.

@krafit krafit added this to the 1.0.3 milestone Jan 9, 2021
@Zodiac1978 Zodiac1978 linked an issue Jan 10, 2021 that may be closed by this pull request
10 tasks
@Zodiac1978
Copy link
Contributor

I have checked with https://wpseek.com/pluginfilecheck/ and the Requires at least: 4.4 needs to be changed:

These two functions are only available since 4.5
get_custom_logoused in template-tags.php
has_custom_logoused in template-tags.php

But there is a check against them:

/* Test if WordPress version and whether a logo has been defined */
function popper_custom_logo() {
	if ( function_exists( 'the_custom_logo' ) && has_custom_logo() ) {
		return get_custom_logo();
	} else {
		return false;
	}
}

The next required version according to the pluginfilecheck is 4.1.

The latest possible WordPress version according to https://wpseek.com/pluginfilecheck/ is 4.5 (which has a function exists check), so the next latest required version is 4.1
@Zodiac1978 Zodiac1978 merged commit 8d3c624 into master Jan 16, 2021
@Zodiac1978 Zodiac1978 deleted the 19-stylecss-updates branch January 16, 2021 13:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theme Check reports some errors, warnings and recommendations
2 participants