Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu should not be focusable and doesn't need to support events #1140

Closed

Conversation

NickClark
Copy link

@NickClark NickClark commented Nov 1, 2023

📑 Description

Currently the SVG image inside the NavHamburger get's focused as well. Since the Menu component doesn't need to be focused in this case, the SVG needs it's role changed and made un-focusable so that the button can retain the focus.

After focus Current:
image

After focus with MR:
image

Status

  • Completed

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • I have checked the page with https://validator.unl.edu/
  • All the tests have passed
  • My pull request is based on the latest commit (not the npm version).

Copy link

stackblitz bot commented Nov 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 11:45am
flowbite-svelte-update ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 11:45am

@Ashvith10
Copy link

@NickClark is this about the inconsistent behavior between the Svelte component and the Tailwind component, where clicking on an SVG does not trigger the outline in the former, but works on the latter?

@NickClark
Copy link
Author

@Ashvith10 I started this because it looked horrible, but now that I'm comparing, my fix does seem to make it look and act like the normal, non-Svelte, Flowbite example.

@shinokada
Copy link
Collaborator

Since it has {...$$restProps}, why don't you just add focusable="false"?

@shinokada
Copy link
Collaborator

I close the PR for now.
Thank you for your contribution.

@shinokada shinokada closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants