-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the getting started docs #351
Conversation
🧙 Sourcery has finished reviewing your pull request! Tips
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Toon. I especially appreciate the way the units is explained clearly, with the rationale of using old-timey notation.
Thanks for checking. Merging... |
This fixes one of the tasks in #191 and is also useful for #254 and #210.
The getting started guide is split in smaller bite-size parts. This also creates some more room for extending the getting started with a few more examples as mentioned in some of the cited issues.
The contents of the guide has not really changed, except maybe for the text in
gettingstarted/index.rst
I will YOLO-merge this on Friday, June 28, unless reviewed earlier.