fix: update data.property.constraints.planning and more based on fe…

…edback (#50)
theopensystemslab · Oct 10, 2023 · 0a8db06 · 0a8db06
1 parent d9df1ae
commit 0a8db06
Show file tree

Hide file tree

Showing 12 changed files with 2,391 additions and 1,918 deletions.
diff --git a/examples/data/ldcE.ts b/examples/data/ldcE.ts
diff --git a/examples/data/ldcP.ts b/examples/data/ldcP.ts
@@ -61,6 +61,7 @@ export const validLDCP: Schema = {
         x: 493822,
         y: 191603,
         title: '7, BLYTON CLOSE, BEACONSFIELD',
+        singleLine: '7, BLYTON CLOSE, BEACONSFIELD, HP9 2LX',
         source: 'Ordnance Survey',
         uprn: '100080482163',
         usrn: '35200844',
@@ -175,8 +176,8 @@ export const validLDCP: Schema = {
             overlaps: false,
           },
           {
-            value: 'article4.buckinghamshire.caz',
-            description: 'Article 4 Direction area',
+            value: 'article4.caz',
+            description: 'Central Activities Zone (CAZ)',
             overlaps: false,
           },
           {

diff --git a/examples/data/planningPermission.ts b/examples/data/planningPermission.ts
@@ -85,6 +85,7 @@ export const validPlanningPermission: Schema = {
         x: 530787,
         y: 175754,
         title: '40, STANSFIELD ROAD, LONDON',
+        singleLine: '40, STANSFIELD ROAD, LONDON, SW9 9RZ',
         source: 'Ordnance Survey',
         uprn: '100021892955',
         usrn: '21901294',
@@ -183,8 +184,8 @@ export const validPlanningPermission: Schema = {
             overlaps: false,
           },
           {
-            value: 'article4.lambeth.caz',
-            description: 'Article 4 Direction area',
+            value: 'article4.caz',
+            description: 'Central Activities Zone (CAZ)',
             overlaps: false,
           },
           {

diff --git a/examples/data/priorApproval.ts b/examples/data/priorApproval.ts
@@ -65,6 +65,8 @@ export const validPriorApproval: Schema = {
         y: 180515,
         title:
           'INTERNATIONAL SHAKESPEARE GLOBE CENTRE LTD, SHAKESPEARE GLOBE THEATRE, 21, NEW GLOBE WALK, LONDON',
+        singleLine:
+          'INTERNATIONAL SHAKESPEARE GLOBE CENTRE LTD, SHAKESPEARE GLOBE THEATRE, 21, NEW GLOBE WALK, LONDON, SE1 9DT',
         source: 'Ordnance Survey',
         uprn: '200003377200',
         usrn: '22503078',
@@ -115,11 +117,36 @@ export const validPriorApproval: Schema = {
             description: 'Article 4 Direction area',
             overlaps: true,
             entities: [
-              'Central Activities Zone - Change of use from offices to dwelling houses is restricted',
-              'Central Activities Zone - Demolition of commercial buildings and construction of new dwellinghouses is restricted',
-              'Bankside and Borough District Town Centre - Demolition of commercial buildings and construction of new dwellinghouses is restricted',
-              'Central Activities Zone - Change of use from Class E to residential is restricted',
-              'Bankside and Borough District Town Centre - Change of use from Class E to residential is restricted',
+              {
+                name: 'Central Activities Zone',
+                description:
+                  'Change of use from offices to dwelling houses is restricted',
+                source: 'https://www.planning.data.gov.uk/entity/7010000942',
+              },
+              {
+                name: 'Central Activities Zone',
+                description:
+                  'Demolition of commercial buildings and construction of new dwellinghouses is restricted',
+                source: 'https://www.planning.data.gov.uk/entity/7010000944',
+              },
+              {
+                name: 'Bankside and Borough District Town Centre',
+                description:
+                  'Demolition of commercial buildings and construction of new dwellinghouses is restricted',
+                source: 'https://www.planning.data.gov.uk/entity/7010001042',
+              },
+              {
+                name: 'Central Activities Zone',
+                description:
+                  'Change of use from Class E to residential is restricted',
+                source: 'https://www.planning.data.gov.uk/entity/7010001055',
+              },
+              {
+                name: 'Bankside and Borough District Town Centre',
+                description:
+                  'Change of use from Class E to residential is restricted',
+                source: 'https://www.planning.data.gov.uk/entity/7010001153',
+              },
             ],
           },
           {
@@ -173,57 +200,21 @@ export const validPriorApproval: Schema = {
             overlaps: false,
           },
           {
-            value: 'article4.southwark.MA',
-            description: 'Article 4 Direction area',
+            value: 'article4.caz',
+            description: 'Central Activities Zone (CAZ)',
             overlaps: true,
             entities: [],
           },
-          {
-            value: 'article4.southwark.caz',
-            description: 'Article 4 Direction area',
-            overlaps: true,
-            entities: [''],
-          },
-          {
-            value: 'article4.southwark.hmo',
-            description: 'Article 4 Direction area',
-            overlaps: false,
-          },
-          {
-            value: 'designated.nationalPark',
-            description: 'National Park',
-            overlaps: false,
-          },
-          {
-            value: 'article4.southwark.sunray',
-            description: 'Article 4 Direction area',
-            overlaps: false,
-          },
-          {
-            value: 'article4.southwark.railway',
-            description: 'Article 4 Direction area',
-            overlaps: false,
-          },
           {
             value: 'designated.conservationArea',
             description: 'Conservation Area',
             overlaps: false,
           },
-          {
-            value: 'article4.southwark.publichouse',
-            description: 'Article 4 Direction area',
-            overlaps: false,
-          },
           {
             value: 'designated.nationalPark.broads',
             description: 'National Park - Broads',
             overlaps: false,
           },
-          {
-            value: 'article4.southwark.southernrail',
-            description: 'Article 4 Direction area',
-            overlaps: false,
-          },
           {
             value: 'road.classified',
             description: 'Classified Road',