Skip to content

Commit

Permalink
fix: data.property.planning type should use more precise language (#64
Browse files Browse the repository at this point in the history 
)
  • Loading branch information
@jessicamcinchak
jessicamcinchak authored Nov 9, 2023
1 parent f5b402f commit 3d9f187
Show file tree
Hide file tree
Showing 11 changed files with 2,092 additions and 2,238 deletions.
83 changes: 43 additions & 40 deletions examples/data/ldcE.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -151,107 +151,110 @@ export const validLDCE: Schema = {
squareMetres: 2993.67,
},
},
constraints: {
planning: [
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
overlaps: false,
},
planning: {
source: 'https://api.editor.planx.dev/gis/buckinghamshire?geom=test',
designations: [
{
value: 'listed',
description: 'Listed Building',
overlaps: false,
},
{
value: 'article4',
description: 'Article 4 Direction area',
overlaps: true,
entities: [
{
name: 'Whole District excluding the Town of Chesham - Poultry production.',
description:
'Bucks County Council Town and Country Planning Act 1947 Town and Country Planning General Development Order 1950. Re Whole District excluding the Town of Chesham. In relation to poultry production.',
source: 'https://www.planning.data.gov.uk/entity/7010002192',
},
],
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
overlaps: false,
intersects: false,
},
{
value: 'monument',
description: 'Site of a Scheduled Monument',
overlaps: false,
intersects: false,
},
{
value: 'designated',
description: 'Designated land',
overlaps: true,
intersects: true,
entities: [],
},
{
value: 'nature.SAC',
description: 'Special Area of Conservation (SAC)',
overlaps: false,
intersects: false,
},
{
value: 'nature.ASNW',
description: 'Ancient Semi-Natural Woodland (ASNW)',
overlaps: false,
intersects: false,
},
{
value: 'nature.SSSI',
description: 'Site of Special Scientific Interest (SSSI)',
overlaps: false,
intersects: false,
},
{
value: 'locallyListed',
description: 'Locally Listed Building',
overlaps: false,
intersects: false,
},
{
value: 'designated.SPA',
description: 'Special Protection Area (SPA)',
overlaps: false,
intersects: false,
},
{
value: 'designated.WHS',
description: 'UNESCO World Heritage Site or buffer zone',
overlaps: false,
intersects: false,
},
{
value: 'registeredPark',
description: 'Historic Park or Garden',
overlaps: false,
intersects: false,
},
{
value: 'designated.AONB',
description: 'Area of Outstanding Natural Beauty (AONB)',
overlaps: true,
intersects: true,
entities: [{name: 'Chilterns'}],
},
{
value: 'designated.nationalPark',
description: 'National Park',
overlaps: false,
intersects: false,
},
{
value: 'designated.conservationArea',
description: 'Conservation Area',
overlaps: false,
intersects: false,
},
{
value: 'designated.nationalPark.broads',
description: 'National Park - Broads',
overlaps: false,
intersects: false,
},
{
value: 'road.classified',
description: 'Classified Road',
overlaps: false,
intersects: false,
},
],
orders: [
{
value: 'article4',
description: 'Article 4 Direction area',
intersects: true,
entities: [
{
name: 'Whole District excluding the Town of Chesham - Poultry production.',
description:
'Bucks County Council Town and Country Planning Act 1947 Town and Country Planning General Development Order 1950. Re Whole District excluding the Town of Chesham. In relation to poultry production.',
source: 'https://www.planning.data.gov.uk/entity/7010002192',
},
],
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
intersects: false,
},
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
intersects: false,
},
],
},
Expand Down
67 changes: 35 additions & 32 deletions examples/data/ldcP.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -95,97 +95,100 @@ export const validLDCP: Schema = {
squareMetres: 1418.26,
},
},
constraints: {
planning: [
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
overlaps: false,
},
planning: {
source: 'https://api.editor.planx.dev/gis/buckinghamshire?geom=test',
designations: [
{
value: 'listed',
description: 'Listed Building',
overlaps: false,
},
{
value: 'article4',
description: 'Article 4 Direction area',
overlaps: false,
intersects: false,
},
{
value: 'monument',
description: 'Site of a Scheduled Monument',
overlaps: false,
intersects: false,
},
{
value: 'designated',
description: 'Designated land',
overlaps: false,
intersects: false,
},
{
value: 'nature.SAC',
description: 'Special Area of Conservation (SAC)',
overlaps: false,
intersects: false,
},
{
value: 'nature.ASNW',
description: 'Ancient Semi-Natural Woodland (ASNW)',
overlaps: false,
intersects: false,
},
{
value: 'nature.SSSI',
description: 'Site of Special Scientific Interest (SSSI)',
overlaps: false,
intersects: false,
},
{
value: 'locallyListed',
description: 'Locally Listed Building',
overlaps: false,
intersects: false,
},
{
value: 'designated.SPA',
description: 'Special Protection Area (SPA)',
overlaps: false,
intersects: false,
},
{
value: 'designated.WHS',
description: 'UNESCO World Heritage Site or buffer zone',
overlaps: false,
intersects: false,
},
{
value: 'registeredPark',
description: 'Historic Park or Garden',
overlaps: false,
intersects: false,
},
{
value: 'designated.AONB',
description: 'Area of Outstanding Natural Beauty (AONB)',
overlaps: false,
intersects: false,
},
{
value: 'designated.nationalPark',
description: 'National Park',
overlaps: false,
intersects: false,
},
{
value: 'designated.conservationArea',
description: 'Conservation Area',
overlaps: false,
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
overlaps: false,
intersects: false,
},
{
value: 'designated.nationalPark.broads',
description: 'National Park - Broads',
overlaps: false,
intersects: false,
},
{
value: 'road.classified',
description: 'Classified Road',
overlaps: false,
intersects: false,
},
],
orders: [
{
value: 'article4',
description: 'Article 4 Direction area',
intersects: false,
},
{
value: 'article4.caz',
description: 'Central Activities Zone (CAZ)',
intersects: false,
},
{
value: 'tpo',
description: 'Tree Preservation Order (TPO) or zone',
intersects: false,
},
],
},
Expand Down
Loading

0 comments on commit 3d9f187

Please sign in to comment.