chore: better data.proposal.details examples (#54)

theopensystemslab · Oct 16, 2023 · e7fc3a7 · e7fc3a7
1 parent da2302b
commit e7fc3a7
Show file tree

Hide file tree

Showing 8 changed files with 316 additions and 4 deletions.
diff --git a/examples/data/ldcE.ts b/examples/data/ldcE.ts
@@ -325,6 +325,7 @@ export const validLDCE: Schema = {
           squareMetres: 2993.67,
         },
       },
+      date: {},
     },
   },
   result: [

diff --git a/examples/data/ldcP.ts b/examples/data/ldcP.ts
@@ -235,6 +235,14 @@ export const validLDCP: Schema = {
           squareMetres: 1418.26,
         },
       },
+      date: {},
+      details: {
+        extend: {
+          area: {
+            squareMetres: 24,
+          },
+        },
+      },
     },
   },
   result: [

diff --git a/examples/data/planningPermission.ts b/examples/data/planningPermission.ts
@@ -248,7 +248,16 @@ export const validPlanningPermission: Schema = {
           squareMetres: 125.92,
         },
       },
+      date: {
+        start: '2024-05-01',
+        completion: '2024-05-02',
+      },
       details: {
+        extend: {
+          area: {
+            squareMetres: 45,
+          },
+        },
         vehicleParking: {
           type: [
             {
@@ -260,6 +269,144 @@ export const validPlanningPermission: Schema = {
               description: 'Off-street parking for bicycles',
             },
           ],
+          cars: {
+            count: {
+              existing: 1,
+              proposed: 1,
+            },
+            offStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+              club: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+              disabled: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+              other: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+              residents: {
+                count: {
+                  existing: 1,
+                  proposed: 1,
+                },
+              },
+            },
+            onStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+              club: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+              disabled: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+              other: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+              residents: {
+                count: {
+                  existing: 0,
+                  proposed: 0,
+                },
+              },
+            },
+          },
+          vans: {
+            count: {
+              existing: 0,
+              proposed: 0,
+            },
+            offStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+            onStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+          },
+          motorcycles: {
+            count: {
+              existing: 0,
+              proposed: 0,
+            },
+            offStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+            onStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+          },
+          bicycles: {
+            count: {
+              existing: 2,
+              proposed: 2,
+            },
+            offStreet: {
+              count: {
+                existing: 2,
+                proposed: 2,
+              },
+            },
+            onStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+          },
+          buses: {
+            count: {
+              existing: 0,
+              proposed: 0,
+            },
+            offStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+            onStreet: {
+              count: {
+                existing: 0,
+                proposed: 0,
+              },
+            },
+          },
         },
       },
     },

diff --git a/examples/validLawfulDevelopmentCertificateExisting.json b/examples/validLawfulDevelopmentCertificateExisting.json
@@ -513,7 +513,8 @@
           "hectares": 0.299367,
           "squareMetres": 2993.67
         }
-      }
+      },
+      "date": {}
     }
   },
   "result": [

diff --git a/examples/validLawfulDevelopmentCertificateProposed.json b/examples/validLawfulDevelopmentCertificateProposed.json
@@ -301,6 +301,14 @@
           "hectares": 0.141826,
           "squareMetres": 1418.26
         }
+      },
+      "date": {},
+      "details": {
+        "extend": {
+          "area": {
+            "squareMetres": 24
+          }
+        }
       }
     }
   },

diff --git a/examples/validPlanningPermission.json b/examples/validPlanningPermission.json
@@ -277,7 +277,16 @@
           "squareMetres": 125.92
         }
       },
+      "date": {
+        "start": "2024-05-01",
+        "completion": "2024-05-02"
+      },
       "details": {
+        "extend": {
+          "area": {
+            "squareMetres": 45
+          }
+        },
         "vehicleParking": {
           "type": [
             {
@@ -288,7 +297,145 @@
               "value": "bicycles.offStreet",
               "description": "Off-street parking for bicycles"
             }
-          ]
+          ],
+          "cars": {
+            "count": {
+              "existing": 1,
+              "proposed": 1
+            },
+            "offStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              },
+              "club": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              },
+              "disabled": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              },
+              "other": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              },
+              "residents": {
+                "count": {
+                  "existing": 1,
+                  "proposed": 1
+                }
+              }
+            },
+            "onStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              },
+              "club": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              },
+              "disabled": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              },
+              "other": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              },
+              "residents": {
+                "count": {
+                  "existing": 0,
+                  "proposed": 0
+                }
+              }
+            }
+          },
+          "vans": {
+            "count": {
+              "existing": 0,
+              "proposed": 0
+            },
+            "offStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            },
+            "onStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            }
+          },
+          "motorcycles": {
+            "count": {
+              "existing": 0,
+              "proposed": 0
+            },
+            "offStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            },
+            "onStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            }
+          },
+          "bicycles": {
+            "count": {
+              "existing": 2,
+              "proposed": 2
+            },
+            "offStreet": {
+              "count": {
+                "existing": 2,
+                "proposed": 2
+              }
+            },
+            "onStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            }
+          },
+          "buses": {
+            "count": {
+              "existing": 0,
+              "proposed": 0
+            },
+            "offStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            },
+            "onStreet": {
+              "count": {
+                "existing": 0,
+                "proposed": 0
+              }
+            }
+          }
         }
       }
     }

diff --git a/schema/schema.json b/schema/schema.json
@@ -2179,7 +2179,7 @@
               ],
               "type": "object"
             },
-            "motorcyles": {
+            "motorcycles": {
               "additionalProperties": false,
               "properties": {
                 "count": {

diff --git a/types/schema/data/Proposal.ts b/types/schema/data/Proposal.ts
@@ -77,7 +77,7 @@ export interface LondonDetails extends BaseDetails {
       onStreet?: VehicleParkingCount;
       offStreet?: VehicleParkingCount;
     };
-    motorcyles?: {
+    motorcycles?: {
       count: {
         existing: number;
         proposed: number;
-Original file line number
+Diff line change
@@ Expand Up / @@ -325,6 +325,7 @@ export const validLDCE: Schema = { @@
               squareMetres: 2993.67,
             },
           },
+          date: {},
         },
       },
       result: [
@@ Expand Down @@