Move source to BaseMetadata type

[jessicamcinchak]

No description provided.

[aaronwilliamsv1]

So as I understand it, source is currently a property of the extended interface PlanXMetaData:

digital-planning-data-schemas/types/schema/Metadata.ts

Lines 38 to 49 in 1fb9bf2

	/**
	* @id #PlanXMetadata
	* @description Additional metadata associated with applications submitted via PlanX
	*/
	export interface PlanXMetadata extends BaseMetadata {
	source: 'PlanX';
	service: {
	flowId: UUID;
	url: URL;
	files: RequestedFiles;
	};
	}

And this issue is to move it from the extended interface, to the BaseMetaData interface:

digital-planning-data-schemas/types/schema/Metadata.ts

Lines 14 to 26 in 1fb9bf2

	export interface BaseMetadata {
	/**
	* @description The reference code for the organisation responsible for processing this planning application, sourced from planning.data.gov.uk/dataset/local-authority
	* @maxLength 4
	*/
	organisation: string;
	/**
	* @description Unique identifier for this application
	*/
	id: UUID; // @todo align to DLUHC Planning Application API reference
	submittedAt: DateTime;
	schema: URL;
	}

My question would be, what should be the default for source? Should it still be 'PlanX'? What is a 'default' organisation? Should it still be string?

[jessicamcinchak]

@aaronwilliamsv1 thanks for questions here, please see latest proposal #119

Proposed changes:

• source becomes required using an enum type, with a "default" state of "Any" (open to language suggestions here!)
• organisation remains required and any string value without a "default". As I understand it, organisation will always reflect data.property.address (required).