Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require metadata.source for any provider, not only Planx #119

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Feb 13, 2024

An alternative enum approach to #118 - no strong opinions, up for discussion !

The enum perhaps offers a slightly more clear "default" state as asked here #117 (comment). "Any" very much feels like a placeholder until another user comes along and defines their own proper metadata (eg 'Any' | 'PlanX' | 'PlanningPortal')

Fixes #117

@DafyddLlyr
Copy link
Contributor

Yep - this works as expected for me!

image

@jessicamcinchak jessicamcinchak marked this pull request as ready for review February 13, 2024 15:11
@jessicamcinchak jessicamcinchak requested a review from a team February 13, 2024 15:11
@jessicamcinchak jessicamcinchak merged commit 3a2211d into main Feb 13, 2024
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/metadata-source branch February 13, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move source to BaseMetadata type
2 participants