Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extend FileTypes enum #100

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

jessicamcinchak
Copy link
Member

@jessicamcinchak jessicamcinchak commented Jan 26, 2024

This PR introduces a breaking change - but one that we think will be a much more meaningful and scalable naming convention going forward for communicating about uploaded documents, drawings, and the types of information contained in them.

Changes:

@jessicamcinchak jessicamcinchak marked this pull request as ready for review February 2, 2024 09:04
@jessicamcinchak jessicamcinchak requested a review from a team February 2, 2024 09:05
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small PR but a lot of work behind the scenes!

I've started looking at the file rules changes discussed earlier this week - might make sense to hold off a little while here and publish one set of breaking changes once I've caught up with the BOPS team?

@jessicamcinchak jessicamcinchak merged commit 5e29d13 into main Feb 2, 2024
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/expand-file-types branch February 2, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants