feat: Add RequestedFiles (v2)
#107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
force-pushed
the
dp/service-files
branch
from
1c6bd52 to
be0f6ea
Compare
DafyddLlyr
force-pushed
the
dp/service-files
branch
from
be0f6ea to
3a0dc61
Compare
DafyddLlyr
changed the title
ServiceFiles to schemaRequestedFiles to schema
DafyddLlyr
commented
Feb 7, 2024
| * @id #RequestedFileType | ||
| * @description Types of planning documents and drawings, with an attached condition as presented to the applicant | ||
| */ | ||
| export type RequestedFileType = FileType & {condition: FileCondition}; |
There was a problem hiding this comment.
As we're relying on the enum FileTypes to dynamically generate the FileType type, we can't extend this interface -
This means that the schema repeats the file list (have a look at the diff in schema.json).
I spent a fair bit of time trying to work around this to no success. The closest would be something like the below which works as as JSON schema "allOf" and does not repeat the FileType definition -
export type RequestedFileType = {file: FileType} & {condition: FileCondition};Both have some compromises - I think the current version (enum duplication, but a more useful data shape) is probably the least worst option here.
I think we're fine to proceed as-is, we can maybe re-evaluate how we handle these enum types at some point (see #51)
DafyddLlyr
changed the title
RequestedFiles to schemaRequestedFiles (v2)
|
Closed in favour of #110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
service.metadata.files