Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update example files urls #139

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

jessicamcinchak
Copy link
Member

Some example files were hitting up against our 6 month retention period and removed from S3, therefore throwing this error when BOPS tries to download if submitted: Error: Failed to download private file: NoSuchKey: The specified key does not exist. (https://planx.airbrake.io/projects/329753/groups/3759175601873853255)

There's a larger piece of work to update example data more robustly, but these fresh files will make existing example payloads usable in meantime!

@jessicamcinchak jessicamcinchak marked this pull request as ready for review March 15, 2024 15:19
@jessicamcinchak jessicamcinchak requested a review from a team March 15, 2024 15:19
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! That's an interesting one I hadn't anticipated.

Agreed - this easily buys us 6 months to think about this one 👍

@jessicamcinchak jessicamcinchak merged commit b8efe69 into main Mar 15, 2024
3 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/update-expired-files branch March 15, 2024 15:55
@jessicamcinchak
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants