Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Residential Unit types captured via List component #192

Merged
merged 4 commits into from
Jul 3, 2024
Merged

feat: add Residential Unit types captured via List component #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cdd8ad
extend interface with omission to share keys btwn UK & GLA
jessicamcinchak Jul 1, 2024
04c0bb9
full res unit types, refactor enum definitions
jessicamcinchak Jul 2, 2024
0d6d690
full res unit types, refactor enum definitions
jessicamcinchak Jul 2, 2024
4cb62e2
update prior approval example
jessicamcinchak Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion examples/data/priorApproval/convertCommercialToHome.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,41 @@ export const priorApprovalConvertCommercialToHome: Schema = {
difference: 0,
},
},
units: {
residential: {
rebuilt: [
{
development: {value: 'changeOfUse', description: 'Change of use'},
type: {value: 'terraced', description: 'Terraced home'},
bedrooms: 3,
habitableRooms: 7,
area: {squareMetres: 300},
tenure: {value: 'marketForRent', description: 'Market for rent'},
provider: {value: 'private', description: 'Private'},
garden: false,
sheltered: false,
olderPersons: false,
compliance: [
{
value: 'm42',
description: 'Part M4(2) of the Building Regulations 2010',
},
{
value: 'm432a',
description:
'Part M4(3)(2a) of the Building Regulations 2010',
},
{
value: 'm432b',
description:
'Part M4(3)(2b) of the Building Regulations 2010',
},
],
identicalUnits: 1,
},
],
},
},
energy: {
type: ['heatPump'],
heatPumps: {
Expand Down Expand Up @@ -1523,7 +1558,7 @@ export const priorApprovalConvertCommercialToHome: Schema = {
source: 'PlanX',
service: {
flowId: 'f3cae2c8-9a64-4ce1-8cef-8e6832ad383d',
url: 'https://editor.planx.uk/lambeth/apply-for-prior-approval/published',
url: 'https://editor.planx.dev/lambeth/apply-for-prior-approval/published',
files: {
required: [
{
Expand Down
49 changes: 48 additions & 1 deletion examples/priorApproval/convertCommercialToHome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,53 @@
"difference": 0
}
},
"units": {
"residential": {
"rebuilt": [
{
"development": {
"value": "changeOfUse",
"description": "Change of use"
},
"type": {
"value": "terraced",
"description": "Terraced home"
},
"bedrooms": 3,
"habitableRooms": 7,
"area": {
"squareMetres": 300
},
"tenure": {
"value": "marketForRent",
"description": "Market for rent"
},
"provider": {
"value": "private",
"description": "Private"
},
"garden": false,
"sheltered": false,
"olderPersons": false,
"compliance": [
{
"value": "m42",
"description": "Part M4(2) of the Building Regulations 2010"
},
{
"value": "m432a",
"description": "Part M4(3)(2a) of the Building Regulations 2010"
},
{
"value": "m432b",
"description": "Part M4(3)(2b) of the Building Regulations 2010"
}
],
"identicalUnits": 1
}
]
}
},
"energy": {
"type": [
"heatPump"
Expand Down Expand Up @@ -1573,7 +1620,7 @@
"source": "PlanX",
"service": {
"flowId": "f3cae2c8-9a64-4ce1-8cef-8e6832ad383d",
"url": "https://editor.planx.uk/lambeth/apply-for-prior-approval/published",
"url": "https://editor.planx.dev/lambeth/apply-for-prior-approval/published",
"files": {
"required": [
{
Expand Down
Loading