feat: Prior Approval (larger extension) example payload #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use blue plaque address - Populate description - Remove optional `metadata.fee.category`
DafyddLlyr
commented
Jul 3, 2024
jessicamcinchak
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Thanks for this one! Overall very happy for it to merge as-is.
Double-checking the original passport, there are a number of interesting/relevant proposal.extension variables that we don't have typed yet which would be nice to include as structured data in future (rather than only within responses here): https://api.editor.planx.dev/admin/session/80d3c3c2-0d1c-4a79-be99-912f488c2f02/summary
|
Rebased this one, fixed conflict & going to merge ! Thanks again for queuing up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #181 as the re-organisation of the examples caused a messy rebase.
Apologies for the delay in getting back to this one!
To do