Update example to include designations #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for this contribution! Could you please propose it as a new payload - eg fullHouseholderInConservationArea rather than overwriting existing?
More variants the merrier (but don't want to eliminate any without warning in case someone esle is relying on project types or other areas of sample app data etc) !
EGiataganas
force-pushed
the
fullHouseHolder-designations
branch
2 times, most recently
from
5f4fcaf to
148b3c6
Compare
There was a problem hiding this comment.
One more ask - can you please follow the commands here so that this PR includes two file changes including the automatically generated JSON example? https://github.com/theopensystemslab/digital-planning-data-schemas?tab=readme-ov-file#adding-examples-and-testing
EGiataganas
force-pushed
the
fullHouseHolder-designations
branch
from
148b3c6 to
bf941cf
Compare
jessicamcinchak
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has come up from POs, as every time they want to demo a planning application with designations, they have to go through the whole process. They have created a planning application with fake data and designations and requested that these data be used so that they can generate it in Swagger automatically.