fix: Update @next GitHub action
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
commented
Jul 25, 2024
| @@ -1,4 +1,4 @@ | |||
| import { Application } from "../../../../types/schemas/application"; | |||
| import {Application} from '../../../../types/schemas/application'; | |||
There was a problem hiding this comment.
Picked up by gts
DafyddLlyr
force-pushed
the
dp/@next-action-fix
branch
from
df515f3 to
2e12ab2
Compare
DafyddLlyr
commented
Jul 25, 2024
| @@ -61,10 +61,6 @@ jobs: | |||
| git fetch origin dist | |||
| git checkout -b dist origin/dist | |||
|
|
|||
| - name: Cleanup old /latest folder | |||
There was a problem hiding this comment.
Removing this as I realised it won't actually work as expected here - being called here it would remove the newly generated version.
I think this is realistically an edge case, as the main schema file which exists here to be accessed by the /latest URL will be stable.
jessicamcinchak
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action is currently failing due to the way generating new files and checking out dist is working. Adding the -f (force) flag resolves this.