Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: write a prototypeApplication schema with definitions based on primary application type #236

Merged
merged 13 commits into from
Sep 19, 2024
Merged

feat: write a prototypeApplication schema with definitions based on primary application type #236

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
345a2e6
rewrite data.applicant, remove data.user
jessicamcinchak Aug 29, 2024
c16aa9f
setup examples data for prototype application
jessicamcinchak Sep 10, 2024
69fa626
share responses and metadata, define prototype applicant and property
jessicamcinchak Sep 13, 2024
fee54da
add back application data types
jessicamcinchak Sep 17, 2024
df6f4a5
add back application data types
jessicamcinchak Sep 17, 2024
5584845
data.proposal plus all pp examples
jessicamcinchak Sep 17, 2024
834f4a4
fix pp examples
jessicamcinchak Sep 17, 2024
5ccaad1
all remaining PA examples
jessicamcinchak Sep 18, 2024
7bc00b4
correct metadata file requirement enums
jessicamcinchak Sep 18, 2024
c766ace
correct schema URLs for all examples
jessicamcinchak Sep 18, 2024
e694fed
tidy unused imports
jessicamcinchak Sep 18, 2024
b187eae
pr feedback
jessicamcinchak Sep 19, 2024
f88f0c1
add GBP units
jessicamcinchak Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/application/data/landDrainageConsent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,6 @@ export const landDrainageConsent: Application = {
payable: [],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we re-organised the file structure, we missed updating existing example payload URLs - so those are handled here! Sorry it makes for another 13 x 2 files changed though 🙈

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!

},
};
2 changes: 1 addition & 1 deletion examples/application/data/lawfulDevelopmentCertificate/existing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1306,6 +1306,6 @@ export const lawfulDevelopmentCertificateExisting: Application = {
},
},
submittedAt: '2023-10-02t00:00:00z',
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/lawfulDevelopmentCertificate/proposed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,6 +899,6 @@ export const lawfulDevelopmentCertificateProposed: Application = {
},
},
submittedAt: '2023-10-02T00:00:00+01:00',
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/listedBuildingConsent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,6 +1188,6 @@ export const listedBuildingConsent: Application = {
notApplicable: true,
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/planningPermission/fullHouseholder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,6 @@ export const planningPermissionFullHouseholder: Application = {
},
},
submittedAt: '2023-10-02T00:00:00.00Z',
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/planningPermission/fullHouseholderInConservationArea.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,6 +1336,6 @@ export const planningPermissionFullHouseholderInConservationArea: Application =
},
},
submittedAt: '2023-10-02T00:00:00.00Z',
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/planningPermission/major.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2191,6 +2191,6 @@ export const planningPermissionMajor: Application = {
payable: [],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/planningPermission/minor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1704,6 +1704,6 @@ export const planningPermissionMinor: Application = {
},
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/priorApproval/buildHomes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1838,6 +1838,6 @@ export const priorApprovalBuildHomes: Application = {
],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/priorApproval/convertCommercialToHome.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,6 +1626,6 @@ export const priorApprovalConvertCommercialToHome: Application = {
],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/priorApproval/extendUniversity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1797,6 +1797,6 @@ export const priorApprovalExtendUniversity: Application = {
],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/priorApproval/largerExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1541,6 +1541,6 @@ export const priorApprovalLargerExtension: Application = {
],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/data/priorApproval/solarPanels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,6 @@ export const priorApprovalSolarPanels: Application = {
],
},
},
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schema.json`,
schema: `https://theopensystemslab.github.io/digital-planning-data-schemas/${version}/schemas/application.json`,
},
};
2 changes: 1 addition & 1 deletion examples/application/landDrainageConsent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1138,6 +1138,6 @@
"payable": []
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/lawfulDevelopmentCertificate/existing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1921,6 +1921,6 @@
}
},
"submittedAt": "2023-10-02t00:00:00z",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/lawfulDevelopmentCertificate/proposed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,6 +1273,6 @@
}
},
"submittedAt": "2023-10-02T00:00:00+01:00",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/listedBuildingConsent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,6 +1221,6 @@
"notApplicable": true
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/planningPermission/fullHouseholder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,6 +1723,6 @@
}
},
"submittedAt": "2023-10-02T00:00:00.00Z",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/planningPermission/fullHouseholderInConservationArea.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1885,6 +1885,6 @@
}
},
"submittedAt": "2023-10-02T00:00:00.00Z",
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/planningPermission/major.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2433,6 +2433,6 @@
"payable": []
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/planningPermission/minor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1693,6 +1693,6 @@
}
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/priorApproval/buildHomes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1905,6 +1905,6 @@
]
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/priorApproval/convertCommercialToHome.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,6 @@
]
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/priorApproval/extendUniversity.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1814,6 +1814,6 @@
]
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/priorApproval/largerExtension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1567,6 +1567,6 @@
]
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
2 changes: 1 addition & 1 deletion examples/application/priorApproval/solarPanels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,6 +1523,6 @@
]
}
},
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schema.json"
"schema": "https://theopensystemslab.github.io/digital-planning-data-schemas/@next/schemas/application.json"
}
}
Loading
Loading