feat: basic schema viewer able to be deployed #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
commented
Oct 9, 2024
Comment on lines
+54
to
+55
| // const _applicationTypeProperty = | ||
| // '$data.application.type.description' || '$applicationType'; |
There was a problem hiding this comment.
Eslint complained that this was an unused variable so have commented out for now.
jamdelion
commented
Oct 9, 2024
| @@ -309,7 +309,7 @@ interface GLAGainedUnit extends GLALostUnit { | |||
| /** | |||
| * TypeMap of PrimaryApplicationTypes to their specific Proposal models | |||
| */ | |||
| type ProposalVariants = {}; | |||
| type ProposalVariants = object; | |||
There was a problem hiding this comment.
Another eslint complaint:
Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
- If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead.
jamdelion
commented
Oct 9, 2024
| @@ -2729,6 +2729,7 @@ export type PropertyType = | |||
| | CommercialUtilityWaterTreatmentWater | |||
| | CommercialUtilityWaterWaste | |||
| | DualUse | |||
| // eslint-disable-next-line @typescript-eslint/ban-types | |||
There was a problem hiding this comment.
ESLint was complaining about (I think) the keyword 'object' even though Object is defined as its own custom type further up the file.
jamdelion
commented
Oct 9, 2024
| <MosaicProvider> | ||
| <Box mx="auto" py={20} px={8} style={{maxWidth: 800}}> | ||
| <JsonSchemaViewer | ||
| // name="Digital planning data schemas" |
There was a problem hiding this comment.
Attributes commented out because causing type errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
/docsfolder containing a create-react-app project featuring@stoplight/json-schema-viewer/schemasinto its own package so it can be imported into the/docsproject.