feat: deploy basic schema viewer using vite #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamdelion
commented
Oct 15, 2024
Comment on lines
+54
to
+55
| // const _applicationTypeProperty = | ||
| // '$data.application.type.description' || '$applicationType'; |
There was a problem hiding this comment.
Eslint complained about unused variables so have commented out for now.
| pnpm i | ||
| pnpm link ../schemas | ||
| pnpm build | ||
| ls -R |
There was a problem hiding this comment.
pnpm link is clever solution here! 💡
| @@ -0,0 +1,10 @@ | |||
| import 'prismjs'; | |||
There was a problem hiding this comment.
👀 ahaa this top-level import prismjs! The relationship between & config required for the core prism lib versus vite prism plugin was stumping me hard, great find 🙌
jessicamcinchak
approved these changes
Oct 16, 2024
jessicamcinchak
added a commit
that referenced
this pull request
Oct 17, 2024
This reverts commit 1dac923.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
/docsfolder containing a vite+react-ts project featuring@stoplight/json-schema-viewer/schemasinto its own package so it can be imported into the/docsproject.main.More context
This is built on top of Jess's work that was originally started in an experimental repo: https://github.com/theopensystemslab/digital-planning-data-schemas-docs/
I have successfully deployed this work to GH Pages in another experimental repo: https://github.com/theopensystemslab/experimental-schema-docs
Once this is merged I will check that it behaves the same in this repo! 🤞