Enable usage testing of the preApplication schema #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
approved these changes
Jan 16, 2025
types/shared/Entity.ts
Outdated
| @@ -0,0 +1,16 @@ | |||
| import {URL} from './utils'; | |||
There was a problem hiding this comment.
Also solved the duplicate Entity definition error via #289 - sorry for conflicts here!
| name: 'PreApplication', | ||
| schema: preApplicationSchema, | ||
| examples: getJSONExamples<PreApplication>('preApplication'), | ||
| }, |
There was a problem hiding this comment.
Much appreciated - fixes #243
| @@ -1,5 +1,8 @@ | |||
| #!/bin/bash | |||
|
|
|||
| set -e | |||
| set -o pipefail | |||
pixeltrix
force-pushed
the
fix-preapp-testing
branch
from
4d465b5 to
0f7db66
Compare
|
@jessicamcinchak rebase to fix the merged conflicts. There was a rollback to version 6.0 of pnpm-lock.yaml in #291 which I think was unintentional so reverting that to version 9.0 is included. |
|
Thanks again @pixeltrix - going to merge this and then rebase and merge #287, then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
build-schemafails when a subprocess failsEntityto a separate file to avoid duplicate definitiontsconfig.buildinfo