fix: update Applicant definition
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Oct 26, 2023
| @@ -43,7 +43,7 @@ describe("parsing using the 'ajv' library", () => { | |||
| examplesToTest.forEach(example => { | |||
| test(`accepts a valid example: ${example.data.application.type.description}`, () => { | |||
| // addFormats() is required for types UUID, email, datetime etc | |||
| const ajv = addFormats(new Ajv()); | |||
| const ajv = addFormats(new Ajv({allowUnionTypes: true})); | |||
There was a problem hiding this comment.
this fixes some warnings that were being thrown when testing, ref https://ajv.js.org/strict-mode.html#union-types
DafyddLlyr
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emily spotted this one today while we were catching up about this work and how it relates to what editors define!
Removes
data.applicant.contact&data.applicant.agent.contactand bumps keys likename,email,phone,companyout to the main level consistent with Planx passport heirarchy. There wasn't any particularly good reason to wrap withincontactin the first place.Once merged and published, I'll update migration guides accordingly (it's unlikely anyone has started parsing yet).