Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
BaseMetadata
andPlanxMetadata
; this feels easier to scale to future contributors & requirements are less coupled to Planx expectationsmetadata.service.name
(instead inferrable fromdata.application.type
)outstanding questions / follow ups:
createdAt
/submittedAt
redundant? does the end-consumer actually care about the length of time between starting and submitting the application? should this is simply be one date that indicates when this payload is being submitted?