v0.2.0 #74
Merged
v0.2.0 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Nov 17, 2023
| ## [0.2.0] - 2023-11-17 | ||
|
|
||
| ### Breaking | ||
| - Renamed `result` to `preAssessment` and made optional, as applications from sources other than Planx are unlikely to provide this ([#66](https://github.com/theopensystemslab/digital-planning-data-schemas/pull/66)) |
There was a problem hiding this comment.
I think this is our first proper truly breaking change which bumps us up to v0.2.0, others agree? There's been a lot of "changing" types in these first weeks that I haven't classified as breaking yet because they began as optional, but that's not the case for result which was originally required.
There was a problem hiding this comment.
Yep - this makes sense to me.
It's all a little abstract until third-parties (BOPS, Uniform) are really using this but it's good to follow best practice here.
DafyddLlyr
requested changes
Nov 17, 2023
| ## [0.2.0] - 2023-11-17 | ||
|
|
||
| ### Breaking | ||
| - Renamed `result` to `preAssessment` and made optional, as applications from sources other than Planx are unlikely to provide this ([#66](https://github.com/theopensystemslab/digital-planning-data-schemas/pull/66)) |
There was a problem hiding this comment.
Yep - this makes sense to me.
It's all a little abstract until third-parties (BOPS, Uniform) are really using this but it's good to follow best practice here.
Co-authored-by: Dafydd Llŷr Pearson <[email protected]>
DafyddLlyr
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.