feat: update depreciation #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gabrielegranello
approved these changes
Dec 6, 2024
DafyddLlyr
requested changes
Dec 6, 2024
DafyddLlyr
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
@zz-hh-aa Really sorry for the holdup here! All looking good :)
zz-hh-aa
force-pushed
the
oz/depreciation-update
branch
from
27fffba to
db7c2d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
constants.tscomponentBreakdownTypebreaks each component down into the percentage of the house it makes up, how much of its original value it depreciates each year, and what percentage of yearly maintenance spend it accounts forhouseBreakdownTypeis an object with a component breakdown object per-componentHOUSE_BREAKDOWN_PERCENTAGESis exported as a constant for use incalculateDepreciatedBuildPrice()Property.tscalculateComponentValue()method (separated this out for ease of testing)calculateDepreciatedBuildPrice()HOUSE_BREAKDOWN_PERCENTAGESand runscalculateComponentValue()to calculate depreciated value per-componentProperty.test.tsTests now pass! I ended up opting for a different method where stuff gets calculated again in the test file. Felt a bit more meaningful than just passing the resultant number as the expected value.
Closes #154