-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculate resale values in Lifetime
class
#149
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
to instantiate all classes with simple values
DafyddLlyr
approved these changes
Dec 6, 2024
no need to subtract 1, just need to be consistent
00b65ff
to
b4b283d
Compare
Lifetime
classLifetime
class
test: test helper functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
In
Lifetime.ts
depreciatedHouseResaleValue
,fairholdLandPurchaseResaleValue
andhouseAge
properties for resale values (as these will be calculated over 'lifetimes' as well)lifetime
calculateDepreciatedBuildPrice()
method inProperty
public because we'll need to call it inLifetime
Why
For story 4 in the calculator, we'll need resale values. Since they also need to be calculated over longer timespans eg lifetime, I thought it made sense to add them to the
Lifetime
class, as it had the most appropriate data structure.I would like to merge #151 first so that I can use the helper functions to write tests for this class (that's why this is still a draft, no test file exists for
Lifetime.ts
yet).Closes #153