feat: Rename build_prices table, make fields non-nullable
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
changed the title
build_prices table, make fields non-nullable
zz-hh-aa
reviewed
Dec 6, 2024
| /* | ||
| Warnings: | ||
|
|
||
| - You are about to drop the `buildprices` table. If the table is not empty, all the data it contains will be lost. |
There was a problem hiding this comment.
Should warnings be removed after the query is updated to use RENAME instead of DROP?
There was a problem hiding this comment.
Good spot thanks - yes! We should keep relevant warnings (very good for PRs) but remove redundant/incorrect ones. I'll fix this shortly 👍
There was a problem hiding this comment.
Please see ced8b00
This was referenced Dec 12, 2024
zz-hh-aa
pushed a commit
that referenced
this pull request
Dec 18, 2024
* feat: Rename `build_prices` table, make not null * fix: Update code now that field in non-nullable * fix: Drop redundant warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
buildpricestable