feat: Rename HPI table columns, add not null constraints
#164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
changed the title
HPI table columns, add not null constraints
DafyddLlyr
force-pushed
the
dp/hpi-table
branch
from
2d8d250 to
306f189
Compare
zz-hh-aa
reviewed
Dec 6, 2024
| @@ -5,6 +5,7 @@ const getHPIByITL3 = async (itl3: string): Promise<number> => { | |||
| const { | |||
| _avg: { hpi2000: averageHpi }, | |||
| } = await prisma.hPI.aggregate({ | |||
| // TODO: Should there be a relationship on ITL3? | |||
There was a problem hiding this comment.
Not quite sure what you mean by this?
There was a problem hiding this comment.
One to talk through next week and add to the backlog I think. We're currently just string matching on the start/end of an itl3 in multiple tables.
What we might actually want to model is an ITL3 table, with relationships to other tables. This would be more efficient when it comes to queries and allow us to join multiple tables. Something like this maybe?
model Itl3 {
id Int @id @default(autoincrement())
code String @unique @db.VarChar(250)
name String @db.VarChar(250)
// Relationships
GDHI GDHI[]
HPI HPI[]
Rent Rent[]
SocialRentEarnings SocialRentEarnings[]
GasBills GasBills[]
ItlLookup ItlLookup[]
@@map("itl3")
}There was a problem hiding this comment.
I think I see what you mean! Will make a note and we can talk through it at next dev call :)
DafyddLlyr
force-pushed
the
dp/ghdi-table
branch
from
e4158df to
606e53c
Compare
zz-hh-aa
requested changes
Dec 13, 2024
prisma/migrations/20241206160747_update_build_prices_names/migration.sql
Outdated
Show resolved
Hide resolved
prisma/migrations/20241206161734_make_build_prices_fields_required/migration.sql
Outdated
Show resolved
Hide resolved
DafyddLlyr
force-pushed
the
dp/hpi-table
branch
from
306f189 to
5ff2d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ladcodetolad_codeNOT NULLconstraints to columns