feat: migration rename columns in gas_bills table
#166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
requested changes
Dec 13, 2024
prisma/schema.prisma
Outdated
| itl String @db.VarChar | ||
| bill Float | ||
| itl1 String @db.VarChar | ||
| kwh_cost_pence Float |
There was a problem hiding this comment.
We also want to map this to camelCase 👍
Suggested change
| kwh_cost_pence Float | |
| kwhCostPence Float @map("kwh_cost_pence") |
There was a problem hiding this comment.
Still missing an @map here which would mean we can use camelCase not snake_case in getGasBillByITL3()
There was a problem hiding this comment.
Ah thanks for catching! Missed that one, should be fixed now at 28c4631
Excuse the strategy day multitasking brain carelessness 😅
zz-hh-aa
force-pushed
the
oz/gas-bills-migration
branch
from
4388f28 to
48cddce
Compare
DafyddLlyr
requested changes
Dec 18, 2024
prisma/schema.prisma
Outdated
| itl String @db.VarChar | ||
| bill Float | ||
| itl1 String @db.VarChar | ||
| kwh_cost_pence Float |
There was a problem hiding this comment.
Still missing an @map here which would mean we can use camelCase not snake_case in getGasBillByITL3()
zz-hh-aa
force-pushed
the
oz/gas-bills-migration
branch
from
07d2f98 to
f9f04e7
Compare
zz-hh-aa
force-pushed
the
oz/gas-bills-migration
branch
from
f9f04e7 to
28c4631
Compare
DafyddLlyr
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
gas_billscolumnsWhy?
I was starting on the data update migration and realised the shape of the gas bills data will change. It seemed like this would need to happen in two steps anyway (data change and schema change) so I figured we could rename the columns first, as the supplied CSVs are already in the next shape.
Questions
...do I need to update the tests to get everything passing even if we're just about to update the data anyway? 😅