feat: rename gdhi column #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DafyddLlyr
approved these changes
Dec 18, 2024
app/data/gdhiRepo.ts
Outdated
| }); | ||
|
|
||
| return gdhi2020; | ||
| console.log('Result:', gdhi); |
There was a problem hiding this comment.
nit: Could we remove this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating data I realised data naming pattern was inconsistent. I think we should stick to the pattern where there is no year suffix when the data is for the relevant year (2022) since that is what we are doing across all other tables, and only include a year suffix when the data is from a specific, older year (eg hpi_2000 because the social rent formula uses values from 2000).
Fixed (updated repo & renamed) version of #184